Skip to content

datasense.js.org #10143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 11, 2025
Merged

datasense.js.org #10143

merged 1 commit into from
Sep 11, 2025

Conversation

kingcean
Copy link
Contributor

@kingcean kingcean commented Sep 10, 2025 •
edited
Loading

The site content is about the introduction of JS lib DataSense.

Screenshot 2025-09-10 113703

@kingcean kingcean mentioned this pull request Sep 10, 2025
Merged
2 tasks
MattIPv4
MattIPv4 approved these changes Sep 10, 2025
View reviewed changes
Copy link
Member

@MattIPv4 MattIPv4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Commit valid, CNAME present, site appears to have content *

* based off https://github.com/compositejs/datasense/tree/main/docs

@MattIPv4 MattIPv4 added add This PR/issue is regarding adding a new subdomain organisation This PR/issue is regarding a target on a GitHub organisation project This PR has a target of a project on an organisation or user account labels Sep 10, 2025
@indus indus added the awaiting custom domain This PR is waiting for the GitHub Pages target to set the custom domain label Sep 10, 2025
@indus
Copy link
Member

indus commented Sep 10, 2025

I've already added your requested subdomain to JS.ORGs zonefile. But I only get a GitHub error page. Can you try to remove and re-add the CNAME file and check the repo-setting that lets you choose docs as the root of the page.
I'll merge after we have "contact". Please keep this PR open.

This was referenced Sep 10, 2025
Merged
Merged
@kingcean
Copy link
Contributor Author

It works now. And so do other two.
Thank you for approving my request.

@indus indus removed the awaiting custom domain This PR is waiting for the GitHub Pages target to set the custom domain label Sep 11, 2025
@indus
Copy link
Member

indus commented Sep 11, 2025

Welcome https://datasense.js.org

@indus indus merged commit ba66dee into js-org:master Sep 11, 2025
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MattIPv4 MattIPv4 MattIPv4 approved these changes

Assignees
No one assigned
Labels
add This PR/issue is regarding adding a new subdomain organisation This PR/issue is regarding a target on a GitHub organisation project This PR has a target of a project on an organisation or user account
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kingcean @indus @MattIPv4