Abstract the request Handler #33
Conversation
| serverAddHandler(server, dashboard); | ||
| serverAddHandler(server, home); | ||
| serverAddHandler(server, session); | ||
| serverAddRoute(server, NONE, NULL, notFound); |
There was a problem hiding this comment.
Can you think of the better way to decouple the following routing rules from main function? I expect the modularized URI handlers can be maintained without the hooks in main function.
There was a problem hiding this comment.
Do you mean separate the handler to another file?
There was a problem hiding this comment.
Yes, the design is intended to work with FastCGI model later: http://kristaps.bsd.lv/kcgi/
We should eliminate the dependency of given route handlers in main module.
There was a problem hiding this comment.
It is beyond my knowledge, I have no idea how to modify
There was a problem hiding this comment.
Instead, you can split the handler in a dedicated routine as cgi_url_dltrie.c does.
There was a problem hiding this comment.
Got it, I'll try to modify it, and notice you when it's done
2 participants
By exposing the interface of
routeHandle, the server won't call the handler directly.Thus, in this PR, I separate the route matching component.
In the future, one may combine some common shared task (middleware? eg: authetication) with routes, i.e. one can extend
routeHandle.