Skip to content

Conversation

@bjohansebas
Copy link
Member

I'll start from version 10, since we want to support HTTP2 directly in the tests (#16)

@bjohansebas bjohansebas force-pushed the node>18 branch 3 times, most recently from 739b7b0 to 6dd6041 Compare March 6, 2025 22:36
@bjohansebas
Copy link
Member Author

Well, I think we can start from node 12 :)

@bjohansebas bjohansebas mentioned this pull request May 15, 2025
2 tasks
Copy link
Member

@ctcpip ctcpip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking at the http/2 PR as it is right now, it doesn't look like we'll actually need to drop support for old node yet. I mean, we can conditionally execute test behavior based on feature detection -- which we already do

Copy link
Member

@blakeembrey blakeembrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto to @ctcpip's comments. I'm not against bumping the minimum node version, but I'd prefer to do it when we have major changes to the API.

I'm also sympathetic to it potentially being a maintenance burden for old versions but that's not what I've seen so far.

@bjohansebas
Copy link
Member Author

If you don’t want to make the change to a major Node version yet, I’m perfectly fine with that

@bjohansebas bjohansebas deleted the node>18 branch July 11, 2025 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants