Skip to content

fix(transloco): prevent loading translations when injector is destroyed #835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(transloco): prevent loading translations when injector is destroyed #835

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions libs/transloco/src/lib/transloco.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,6 +109,7 @@ export class TranslocoService {
};

private destroyRef = inject(DestroyRef);
private destroyed = false;

constructor(
@Optional() @Inject(TRANSLOCO_LOADER) private loader: TranslocoLoader,
Expand Down Expand Up @@ -144,6 +145,7 @@ export class TranslocoService {
});

this.destroyRef.onDestroy(() => {
this.destroyed = true;
// Complete subjects to release observers if users forget to unsubscribe manually.
// This is important in server-side rendering.
this.lang.complete();
Expand Down Expand Up @@ -193,6 +195,14 @@ export class TranslocoService {
}

load(path: string, options: LoadOptions = {}): Observable<Translation> {
// If the application has already been destroyed, return an empty observable.
// We use EMPTY instead of NEVER to ensure the observable completes.
// This is important for operators like switchMap, which rely on the inner observable completing
// before they can subscribe to the next one. NEVER would hang the chain indefinitely.
if (this.destroyed) {
return EMPTY;
}

const cached = this.cache.get(path);
if (cached) {
return cached;
Expand Down