Skip to content

add --optimize development option #251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

add --optimize development option #251

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
aa300de
add --optimize development option (alias for --optimize release --dis…
nyuichi Aug 18, 2013
105f30f
fix a bug(typo) introduced in the prev commit
nyuichi Aug 18, 2013
8ab111c
getDevelOptCmds to use the result of getReleaseOptCmds
nyuichi Aug 18, 2013
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/jsx-command.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,6 +189,8 @@ class JSXCommand {
}
if (optarg == "release") {
optimizeCommands = Optimizer.getReleaseOptimizationCommands();
} else if (optarg == "development") {
optimizeCommands = Optimizer.getDevelopmentOptimizationCommands();
} else {
optimizeCommands = optimizeCommands.concat(optarg.split(","));
}
Expand Down
11 changes: 11 additions & 0 deletions src/optimizer.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,6 +251,17 @@ class Optimizer {
];
}

static function getDevelopmentOptimizationCommands() : string[] {
var disabled = [
"no-assert",
"no-log",
"no-debug"
];
return Optimizer.getReleaseOptimizationCommands().filter(function (cmd) {
return disabled.indexOf(cmd) == -1;
});
}

function constructor () {
this._compiler = null;
this._commands = new _OptimizeCommand[];
Expand Down