Skip to content

Conversation

@Pankraz76
Copy link
Contributor


I hereby agree to the terms of the JUnit Contributor License Agreement.


Definition of Done

@Pankraz76 Pankraz76 force-pushed the fix-makeReadable-whitespace-remove-null branch from 235b86b to e1db4c4 Compare July 9, 2025 10:15
@Pankraz76
Copy link
Contributor Author

Pankraz76 commented Jul 9, 2025

BUILD SUCCESSFUL in 2s

Copy link
Contributor Author

@Pankraz76 Pankraz76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2cts.

}
return result;
@Nullable
private List<Object> makeReadable(@Nullable Object[] arguments) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe dont change API.

Suggested change
private List<Object> makeReadable(@Nullable Object[] arguments) {
private Object[] makeReadable(@Nullable Object[] arguments) {

@Pankraz76
Copy link
Contributor Author

Pankraz76 commented Jul 9, 2025

how does build or check not execute the tests....

@Pankraz76 Pankraz76 closed this Jul 9, 2025
@Pankraz76 Pankraz76 reopened this Jul 9, 2025
@Pankraz76 Pankraz76 force-pushed the fix-makeReadable-whitespace-remove-null branch from e1db4c4 to 52285ee Compare July 9, 2025 10:29
@Pankraz76 Pankraz76 marked this pull request as ready for review July 9, 2025 10:30
@sormuras
Copy link
Member

sormuras commented Jul 9, 2025

@Pankraz76 - Please stop creating PRs. Start by discussing and socializing ideas and issues here: https://github.com/junit-team/junit-framework/discussions

@sormuras sormuras closed this Jul 9, 2025
@Pankraz76
Copy link
Contributor Author

assuming this is wrong:

7ea357d

@sormuras
Copy link
Member

sormuras commented Jul 9, 2025

assuming this is wrong:

Well. We're assuming it is right. So, let's discuss it. Not in a PR, though.

@marcphilipp
Copy link
Member

@Pankraz76 As @sormuras pointed out in his comment, @Nullable Format[] is how one uses JSpecify's Nullable annotation to express that the array may contain null elements whereas Format @Nullable [] would meant that the array reference may be null but the array must not contain null. Please familiarize yourself with the JSpecify spec before assuming things are wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants