- 
          
 - 
                Notifications
    
You must be signed in to change notification settings  - Fork 1.6k
 
          invert false @Nullable annotation on getFormatsByArgumentIndex
          #4739
        
          New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
  
    invert false @Nullable annotation on getFormatsByArgumentIndex
  
  #4739
              Conversation
235b86b    to
    e1db4c4      
    Compare
  
    | 
           BUILD SUCCESSFUL in 2s  | 
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2cts.
| } | ||
| return result; | ||
| @Nullable | ||
| private List<Object> makeReadable(@Nullable Object[] arguments) { | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe dont change API.
| private List<Object> makeReadable(@Nullable Object[] arguments) { | |
| private Object[] makeReadable(@Nullable Object[] arguments) { | 
        
          
                ...iter-params/src/main/java/org/junit/jupiter/params/ParameterizedInvocationNameFormatter.java
          
            Show resolved
            Hide resolved
        
              
          
                ...iter-params/src/main/java/org/junit/jupiter/params/ParameterizedInvocationNameFormatter.java
          
            Show resolved
            Hide resolved
        
              
          
                ...iter-params/src/main/java/org/junit/jupiter/params/ParameterizedInvocationNameFormatter.java
          
            Show resolved
            Hide resolved
        
              
          
                ...iter-params/src/main/java/org/junit/jupiter/params/ParameterizedInvocationNameFormatter.java
          
            Show resolved
            Hide resolved
        
      | 
           how does build or check not execute the tests....  | 
    
e1db4c4    to
    52285ee      
    Compare
  
    | 
           @Pankraz76 - Please stop creating PRs. Start by discussing and socializing ideas and issues here: https://github.com/junit-team/junit-framework/discussions  | 
    
| 
           assuming this is wrong:  | 
    
          
 Well. We're assuming it is right. So, let's discuss it. Not in a PR, though.  | 
    
| 
           @Pankraz76 As @sormuras pointed out in his comment,   | 
    
I hereby agree to the terms of the JUnit Contributor License Agreement.
Definition of Done
@APIannotations