Introduce org.junit.start module
#5042
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sormuras
changed the title
org.junit.onramp moduleorg.junit.start module
mpkorstanje
reviewed
Oct 21, 2025
| .map(DefaultClasspathScanner::determineSimpleClassName) | ||
| .map(name -> name.replace('/', '.')) | ||
| .filter(name -> !"module-info".equals(name)) | ||
| .filter(name -> !name.endsWith("package-info")) |
There was a problem hiding this comment.
This looks similair to ClasspathFilters.isNotPackageInfo and isNotModuleInfo. If you add a string based variant and call those before .map(DefaultClasspathScanner::determineSimpleClassName) we have that logic in one place.
mpkorstanje
reviewed
Oct 21, 2025
| var listener = new SummaryGeneratingListener(); | ||
| var charset = Charset.defaultCharset(); | ||
| var writer = new PrintWriter(System.out, true, charset); | ||
| var printer = new TreePrintingListener(writer, ColorPalette.DEFAULT, Theme.valueOf(charset)); |
There was a problem hiding this comment.
This doesn't follow the NO_COLOR environment variable.
And will this look good on Windows? (I haven't used it in ages, I have no clue if it supports ANSI yet)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
work in progress...
org.junit.startmodule #4982I hereby agree to the terms of the JUnit Contributor License Agreement.
Definition of Done
@APIannotations