Couple improvements in Notebooks + fix path to vtk file #145
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
mwcraig
reviewed
Jul 9, 2021
| "outputs": [], | ||
| "source": [ | ||
| "mesh2 = TetraMesh.from_vtk('images/piston.vtu')\n", | ||
| "mesh2 = TetraMesh.from_vtk('../images/piston.vtu')\n", |
There was a problem hiding this comment.
Should we just move assets into. this folder?
There was a problem hiding this comment.
Yes I guess it makes more sense
|
I'm going to hold off on this until #135 is in since it touches some of the notebooks here.... |
marimeireles
reviewed
Jul 9, 2021
There was a problem hiding this comment.
Does this removes the image?
I'd like to have it if possible, so I can show some different types of templates you can generate. Unfortunately this is the only way of doing it (generating all the graphs for real would take too long).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.