Skip to content

Ignore the link check of cvedetails.com, since we are getting 403 #812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 8, 2025

Conversation

jasongrout
Copy link
Member

@jasongrout jasongrout commented Aug 8, 2025

We get a 403 when running the link check and trying to visit this URL.

=================================== FAILURES ===================================
_ /home/runner/work/jupyter.github.io/jupyter.github.io/_site/security.html: https://www.cvedetails.com/vulnerability-list/vendor_id-15653/Jupyter.html _
https://www.cvedetails.com/vulnerability-list/vendor_id-15653/Jupyter.html: 403: Forbidden
=============================== warnings summary ===============================
../../../.local/lib/python3.12/site-packages/jupyter_client/connect.py:22
  /home/runner/.local/lib/python3.12/site-packages/jupyter_client/connect.py:22: DeprecationWarning: Jupyter is migrating its paths to use standard platformdirs
  given by the platformdirs library.  To remove this warning and
  see the appropriate new directories, set the environment variable
  `JUPYTER_PLATFORM_DIRS=1` and then run `jupyter --paths`.
  The use of platformdirs will be the default in `jupyter_core` v6
    from jupyter_core.paths import jupyter_data_dir, jupyter_runtime_dir, secure_write

../../../.local/lib/python3.12/site-packages/_pytest/cacheprovider.py:475
  /home/runner/.local/lib/python3.12/site-packages/_pytest/cacheprovider.py:475: PytestCacheWarning: could not create cache path /.pytest_cache/v/cache/nodeids: [Errno 13] Permission denied: '/pytest-cache-files-p1xdd79b'
    config.cache.set("cache/nodeids", sorted(self.cached_nodeids))

../../../.local/lib/python3.12/site-packages/_pytest/cacheprovider.py:429
  /home/runner/.local/lib/python3.12/site-packages/_pytest/cacheprovider.py:429: PytestCacheWarning: could not create cache path /.pytest_cache/v/cache/lastfailed: [Errno 13] Permission denied: '/pytest-cache-files-y0vyvqe1'
    config.cache.set("cache/lastfailed", self.lastfailed)

-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html
=========================== short test summary info ============================
FAILED _site/security.html::/home/runner/work/jupyter.github.io/jupyter.github.io/_site/security.html <a href=https://www.cvedetails.com/vulnerability-list/vendor_id-15653/Jupyter.html>
============ 1 failed, 426 passed, 3 warnings in 112.00s (0:01:52) =============

@jasongrout
Copy link
Member Author

Hooray, the link check works now!

image

@choldgraf choldgraf merged commit f3490f4 into jupyter:main Aug 8, 2025
5 checks passed
@choldgraf
Copy link
Collaborator

Thanks @jasongrout - @krassowski for what it's worth, I think it's fine to just merge these right away rather than approving and waiting. I don't know what kind of "approval / merge policy" this repository has, but in my opinion I trust the judgment of you or anybody else to make the right decision, and to generally bias towards taking action if you think it's a reasonable change.

@jasongrout
Copy link
Member Author

I think a while ago we said there were very strict guidelines about merging to the official Jupyter website and who could merge. But hey, that didn't stop us from messing things up the other day...

Anyways, +1 to merging this, maybe after checking the preview...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants