Skip to content

Experiment with threadpools #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Experiment with threadpools #113

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 6 additions & 8 deletions nbclient/util.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@
import asyncio
import sys
import inspect
import concurrent.futures

from typing import Callable, Awaitable, Any, Union


Expand All @@ -28,6 +30,7 @@ def check_patch_tornado() -> None:
tornado.concurrent.FUTURES = \
tornado.concurrent.FUTURES + (asyncio.Future, ) # type: ignore

pool = concurrent.futures.ThreadPoolExecutor()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason to use more than one thread? I think we should use max_workers=1.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

max_worker should be fine IMO.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you don't specify mar_workers, it will use unnecessary resources: "If max_workers is None or not given, it will default to the number of processors on the machine, multiplied by 5".
Since you never actually run concurrently, you don't need more than 1 thread.


def just_run(coro: Awaitable) -> Any:
"""Make the coroutine run, even if there is an event loop running (using nest_asyncio)"""
Expand All @@ -44,14 +47,9 @@ def just_run(coro: Awaitable) -> Any:
else:
had_running_loop = True
if had_running_loop:
# if there is a running loop, we patch using nest_asyncio
# to have reentrant event loops
check_ipython()
import nest_asyncio
nest_asyncio.apply()
check_patch_tornado()
return loop.run_until_complete(coro)

return pool.submit(asyncio.run, coro).result()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could have only this line in the function, so that we always run in a thread with its own event loop.

else:
return loop.run_until_complete(coro)

def run_sync(coro: Callable) -> Callable:
"""Runs a coroutine and blocks until it has executed.
Expand Down