Skip to content

Backport PR #1417 on branch 2.x (Add VertexAI model provider) #1421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jul 21, 2025

Conversation

meeseeksmachine
Copy link
Contributor

Backport PR #1417: Add VertexAI model provider

@lumberbot-app lumberbot-app bot added the enhancement New feature or request label Jul 18, 2025
@dlqqq
Copy link
Member

dlqqq commented Jul 18, 2025

Oh this needs the fix from #1412. Let me add that...

@dlqqq
Copy link
Member

dlqqq commented Jul 21, 2025

The absolute state of the pip package solver... 😮‍💨

I think a version floor is required for this job to pass.

Screenshot 2025-07-21 at 9 23 43 AM

@dlqqq
Copy link
Member

dlqqq commented Jul 21, 2025

These are the constraints being used in the "minimum dependencies" job at 31169dc:

2025-07-21T16:39:44.7373877Z click==8.1.0
2025-07-21T16:39:44.7374555Z importlib-metadata==5.2.0
2025-07-21T16:39:44.7390034Z jsonpath-ng==1.5.3
2025-07-21T16:39:44.7390496Z langchain-community==0.3.0
2025-07-21T16:39:44.7390957Z langchain==0.3.0
2025-07-21T16:39:44.7391347Z pydantic==2.10.0
2025-07-21T16:39:44.7391733Z cohere==5.12
2025-07-21T16:39:44.7392270Z pre-commit==3.3.3
2025-07-21T16:39:44.7392675Z deepmerge==2.0
2025-07-21T16:39:44.7393080Z faiss-cpu==1.8.0
2025-07-21T16:39:44.7393343Z jupyter-server==2.4.0
2025-07-21T16:39:44.7393576Z traitlets==5.6
2025-07-21T16:39:44.7393812Z syrupy==4.0.8

These constraints all look reasonably up-to-date, so I'm not sure what is causing the package solver to stall endlessly in CI. Notably, the boto3 resolution takes a very long time. It may be because cohere has a dependency on boto3 for some reason, so I will add version constraints on langchain_aws and langchain_cohere.

We may need to backport the upgrade to uv before merging this to have the package solver work faster if this does not work.

@dlqqq
Copy link
Member

dlqqq commented Jul 21, 2025

Sweet, the pins on langchain_aws and langchain_cohere fixed CI. Proceeding to merge.

There should be no user-facing changes introduced by the constraints I added. The new constraints were already implied by our existing langchain>=0.3,<0.4 constraint.

@dlqqq dlqqq merged commit 0fad182 into jupyterlab:2.x Jul 21, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants