-
-
Notifications
You must be signed in to change notification settings - Fork 442
Simplify model parameter REST API #1475
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify model parameter REST API #1475
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jonahjung22 Thank you Jonah! I left a couple of minor suggestions below.
After addressing the feedback, please also re-test this PR now that it is rebased onto main
with #1473 merged.
I recommend running git config --global pull.rebase true
if you haven't already. After running that, running git pull
should sync your local branch with this remote.
packages/jupyter-ai/jupyter_ai/model_providers/parameter_schemas.py
Outdated
Show resolved
Hide resolved
0832060
to
2629b63
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The API looks great now, thank you for fixing it! 🎉
Description:
Code changes:
User facing changes: