Guard add_library calls in Findtest-drive.cmake #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add if(NOT TARGET) guards around add_library calls to prevent conflicts when the target already exists (e.g., when using stdlib with FetchContent after PR fortran-lang#1033 which adds ALIAS targets automatically). This allows users to use the Find module pattern with libraries that already provide namespaced ALIAS targets.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add
if(NOT TARGET)guards aroundadd_librarycalls to prevent conflicts when the target already exists.Context
After PR fortran-lang#1033, stdlib automatically creates namespaced ALIAS targets (e.g.,
fortran_stdlib::stdlib). The example code inFindtest-drive.cmakethat users copy for integrating stdlib via FetchContent was trying to create these same targets, causing CMake errors.Changes
Testing
This allows the FetchContent pattern to work correctly with stdlib after fortran-lang#1033 without requiring users to manually remove the add_library lines.
Fixes the issue described in fortran-lang#1036