refactor(app): remove sensitive Authorization header logging from SteamableHttp MCP server #568
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eamableHttp MCP server
peterj
reviewed
Jun 27, 2025
| async def discover_tools(self) -> list[Component]: | ||
| try: | ||
| logger.debug(f"Discovering tools from streamable http server: {self.config}") | ||
| logger.debug(f"Discovering tools from streamable http server: {self._sanitize_config(self.config)}") |
There was a problem hiding this comment.
nice!
While you're in this code here -- there's a similar logging statement in the _ssemcptoolserver.py and _stdiomcptoolserver.py -- can you run that through the _sanitize_config as well?
peterj
requested changes
Jun 27, 2025
|
Autogen is gone, closing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Authorization decoded secrets is logged freely in kagent app, which is serious security violation.
Example
With GitHub MCP Server I have logged PAT token
Fix
Add config wrapper function that obfuscates Authorization header