introduces createApiKeySecret for #633 #652
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also fixes a minor bug with not allowing users to set a custom secret name Signed-off-by: Kasun Talwatta <[email protected]>
|
Hey @day0ops, I believe there was an issue about exactly this created a few months ago, and I'm fairly certain the takeaway was that we could just use the missing |
|
I'm not opposed to that. I also see a big refactor happening in another PR. Will close this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
createApiKeySecretto override the default secret injection. Users can opt out and inject their own secrets using external tools such as external-secret operator.