Open
Conversation
Update minimatch dependency from previous version to 10.2.4.
minimatch v10 changed from a CommonJS default export to named exports. Update all require statements across lib/ files to destructure the named function and class from the module.
Add check for undefined result when globParts.reduce() returns undefined for empty patterns. This occurs in minimatch v10 when an empty string pattern is passed, causing reduce() on an empty array to return undefined.
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrade minimatch to 10.2.4
Summary
Upgrades minimatch from the previous version to 10.2.4 and fixes all breaking API changes introduced in minimatch v10.
Problem
minimatch v10 changed from a CommonJS default export to named exports. The previous usage of const mm = require('minimatch') no longer returns a function, causing TypeError: mm is not a function at runtime.
Additionally, the Minimatch class is no longer accessible via mm.Minimatch and must be imported as a separate named export.