Skip to content

Conversation

@jokemanfire
Copy link

@jokemanfire jokemanfire commented Aug 1, 2025

I don't think errors should be hidden here, it will cause the error to occur in the subsequent process, and I think this design is incorrect.
you can choose to ignore this error ,but should not hide it in inner.

  let cg = Cgroup::new(hierarchies::auto(), path).unwrap();
  let mem_controller: &MemController = cg.controller_of().unwrap();
  mem_controller.set_limit(10 * 1024 * 1024).unwrap(); // 10M

this will case the panic occur in set_limit,this is unreasonable.

@jokemanfire jokemanfire changed the title fix(Controller): Errors are hidden by defaul fix(Controller): Errors are hidden by default Aug 1, 2025
Fixed an error hidden during the creation of cgroup,
which resulted in subsequent error propagation

Signed-off-by: jokemanfire <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant