Skip to content

Conversation

gman0
Copy link
Contributor

@gman0 gman0 commented Apr 14, 2025

Summary

This PR cleans up the go mod deps to be in line with k/k 1.31.6. Specifically it follows the instructions reported by hack/verify-go-modules.sh (#3373).

/kind cleanup

Related Issue(s)

Part of: #3375

Release Notes

NONE

@kcp-ci-bot kcp-ci-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has signed the DCO. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 14, 2025
@gman0 gman0 marked this pull request as draft April 14, 2025 17:04
@kcp-ci-bot kcp-ci-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 14, 2025
go.mod Outdated
)

// DO NOT MERGE !!!
replace github.com/kcp-dev/embeddedetcd => /tmp/ws/kcp-embeddedetcd
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs kcp-dev/embeddedetcd#1 first.

@gman0 gman0 force-pushed the clean-gomod-deps branch from 52e0c3c to f104e32 Compare April 16, 2025 18:30
@kcp-ci-bot kcp-ci-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 16, 2025
On-behalf-of: SAP [email protected]
Signed-off-by: Robert Vasek <[email protected]>
@gman0 gman0 force-pushed the clean-gomod-deps branch from f104e32 to b3bbd78 Compare April 16, 2025 18:34
@kcp-ci-bot kcp-ci-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 16, 2025
@gman0 gman0 marked this pull request as ready for review April 16, 2025 18:36
@kcp-ci-bot kcp-ci-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 16, 2025
@gman0
Copy link
Contributor Author

gman0 commented Apr 16, 2025

/test pull-kcp-test-e2e-sharded

@mjudeikis
Copy link
Contributor

/lgtm
/approve

@kcp-ci-bot kcp-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 16, 2025
@kcp-ci-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: e8732ddbb64e70eff7c87edef738d71aa6b93a39

@kcp-ci-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mjudeikis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kcp-ci-bot kcp-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 16, 2025
@kcp-ci-bot kcp-ci-bot merged commit 4004244 into kcp-dev:main Apr 16, 2025
10 checks passed
@embik embik added this to the v0.28.0 milestone May 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has signed the DCO. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants