-
-
Notifications
You must be signed in to change notification settings - Fork 40
Absolve kdl-rs
of syn
#125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This completes the removal of `syn` from `kdl-rs`s dependency tree!
@zkat I think I'll need your guidance on how to fix CI here — it's another case of being broken on Is the |
Just bump the MSRV, it's fine |
Needed to update the configuration for |
@TheLostLambda [email protected] is tagged and released |
Would love to see this on crates.io, is a release going out soon-ish? :) |
This adds a few more manual
impl
s in a couple of files, but nets us faster compile times and makeskdl-rs
something that can be used as a dependency offacet-kdl
in the future (facet-rs/facet#387).It also fixes a bug where the
Severity
ofKdlDiagnostics
was always ignored.A final comparison of compile times before and after this change will wait until zkat/miette#436 is released on crates.io (since I think using Git dependencies slows down Cargo a bit?)
The final dependency tree is: