Skip to content

Absolve kdl-rs of syn #125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Apr 28, 2025
Merged

Absolve kdl-rs of syn #125

merged 7 commits into from
Apr 28, 2025

Conversation

TheLostLambda
Copy link
Member

@TheLostLambda TheLostLambda commented Apr 26, 2025

This adds a few more manual impls in a couple of files, but nets us faster compile times and makes kdl-rs something that can be used as a dependency of facet-kdl in the future (facet-rs/facet#387).

It also fixes a bug where the Severity of KdlDiagnostics was always ignored.

A final comparison of compile times before and after this change will wait until zkat/miette#436 is released on crates.io (since I think using Git dependencies slows down Cargo a bit?)

The final dependency tree is:

image

@TheLostLambda
Copy link
Member Author

@zkat I think I'll need your guidance on how to fix CI here — it's another case of being broken on main. It's because kdl-lsp is bringing in tower-lsp which is eventually bringing in [email protected] which needs Rust 1.81.1...

Is the kdl-lsp crate currently included in kdl-rss 1.17.1 MSRV, or should the CI be changed to ignore it when building with 1.17.1?

@zkat
Copy link
Member

zkat commented Apr 26, 2025

Just bump the MSRV, it's fine

@TheLostLambda
Copy link
Member Author

Needed to update the configuration for cargo-dist too, since axodotdev/cargo-dist#1760 hasn't been fixed yet and GitHub wouldn't run the Plan action. Things are all green now!

@zkat
Copy link
Member

zkat commented Apr 27, 2025

@TheLostLambda [email protected] is tagged and released

@TheLostLambda
Copy link
Member Author

Some more modest compile-time improvements than we saw in miette, but not bad overall! Plus, we've fixed a bug and added some tests whilst we were at it!

image

23% improvement in debug build times, and 10% in release!

@zkat zkat merged commit 439aa63 into kdl-org:main Apr 28, 2025
13 checks passed
@jplatte
Copy link

jplatte commented May 6, 2025

Would love to see this on crates.io, is a release going out soon-ish? :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants