Skip to content

Conversation

shashaka
Copy link
Collaborator

Adds keras.ops.isreal, which tests element-wise whether each tensor element has zero imaginary part.
Supported across NumPy, TensorFlow, PyTorch, and JAX backends.
Not supported on OpenVINO.

Copy link
Contributor

Summary of Changes

Hello @shashaka, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces the isreal function to the Keras operations API, providing a consistent and backend-agnostic way to determine if tensor elements are real numbers. This enhancement improves Keras's numerical capabilities, particularly when dealing with complex numbers. Additionally, an implementation for a poly function was included in the TensorFlow backend, which seems to be an unrelated feature.

Highlights

  • New isreal function: A new keras.ops.isreal function has been introduced, designed to test element-wise whether each tensor element has a zero imaginary part, effectively checking if it's a real number.
  • Multi-backend support: The isreal function is implemented and supported across multiple Keras backends, including NumPy, TensorFlow, PyTorch, and JAX, ensuring consistent behavior regardless of the chosen backend.
  • API exposure and testing: The new function is properly exposed through the keras.ops and keras.ops.numpy public APIs. Comprehensive unit tests have been added to verify its functionality, symbolic shape inference, and dtype consistency across various backends and data types.
  • Unrelated poly function addition: An implementation for a poly function was also added to the TensorFlow backend, which appears to be an independent change not directly related to the isreal function.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly implements the isreal operation across the JAX, NumPy, PyTorch, and TensorFlow backends, along with the necessary exports and tests. However, there are a few issues to address. An unrelated poly function has been added to the TensorFlow backend, which should be removed. Additionally, a test for isposinf was mistakenly replaced by a test for isreal instead of adding a new one. Lastly, the docstring for the isreal function is missing a code example, which is required by the repository's style guide.

@codecov-commenter
Copy link

codecov-commenter commented Oct 13, 2025

Codecov Report

❌ Patch coverage is 93.10345% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.63%. Comparing base (3137cb0) to head (0e5ce37).
⚠️ Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
keras/api/_tf_keras/keras/ops/__init__.py 0.00% 1 Missing ⚠️
keras/api/_tf_keras/keras/ops/numpy/__init__.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #21740      +/-   ##
==========================================
+ Coverage   82.59%   82.63%   +0.04%     
==========================================
  Files         572      572              
  Lines       58535    58533       -2     
  Branches     9158     9146      -12     
==========================================
+ Hits        48345    48368      +23     
+ Misses       7853     7840      -13     
+ Partials     2337     2325      -12     
Flag Coverage Δ
keras 82.43% <93.10%> (+0.04%) ⬆️
keras-jax 63.21% <62.06%> (+0.01%) ⬆️
keras-numpy 57.57% <62.06%> (+0.01%) ⬆️
keras-openvino 34.36% <34.48%> (+0.03%) ⬆️
keras-tensorflow 63.96% <68.96%> (+0.02%) ⬆️
keras-torch 63.50% <62.06%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@hertschuh hertschuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@google-ml-butler google-ml-butler bot added kokoro:force-run ready to pull Ready to be merged into the codebase labels Oct 15, 2025
@hertschuh hertschuh merged commit 232cf26 into keras-team:master Oct 15, 2025
11 checks passed
@google-ml-butler google-ml-butler bot removed awaiting review ready to pull Ready to be merged into the codebase labels Oct 15, 2025
@shashaka shashaka deleted the isreal branch October 15, 2025 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants