-
Notifications
You must be signed in to change notification settings - Fork 19.6k
Implement isreal function in keras.ops #21740
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @shashaka, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request correctly implements the isreal
operation across the JAX, NumPy, PyTorch, and TensorFlow backends, along with the necessary exports and tests. However, there are a few issues to address. An unrelated poly
function has been added to the TensorFlow backend, which should be removed. Additionally, a test for isposinf
was mistakenly replaced by a test for isreal
instead of adding a new one. Lastly, the docstring for the isreal
function is missing a code example, which is required by the repository's style guide.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #21740 +/- ##
==========================================
+ Coverage 82.59% 82.63% +0.04%
==========================================
Files 572 572
Lines 58535 58533 -2
Branches 9158 9146 -12
==========================================
+ Hits 48345 48368 +23
+ Misses 7853 7840 -13
+ Partials 2337 2325 -12
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
Adds keras.ops.isreal, which tests element-wise whether each tensor element has zero imaginary part.
Supported across NumPy, TensorFlow, PyTorch, and JAX backends.
Not supported on OpenVINO.