Include redirectUrl even if idTokenHint is not provided #421
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rototype.logoutUrl. Fixes keycloak#420
Author
|
@jonkoops I had trouble getting the test suite in this project to run locally and it also seems like github has issues with it. This fixes an issue we have in production. If it looks ok to you and fast-tracking a release of the fix is possible that would be 🌈 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes what I believe is a bug in the keycloak connect client where it will ignore the redirectUrl passed to logoutUrl if no idTokenHint is provided.
Fixes #420