Fix a bug when determining whether an existing animation has completed#1332
Merged
Fix a bug when determining whether an existing animation has completed#1332
Conversation
mjohnson12
approved these changes
Jul 3, 2025
| result = YES; | ||
| } | ||
| } else if (currentTime > completionTime) { | ||
| } else if (currentTime < completionTime) { |
Collaborator
|
Unfortunately, there might be tests that break now that this is correct. |
Contributor
Author
Yeah, I've been working with @congt to verify this and it appears to not be too bad! Seems doable. A few places that maybe need some more typing delays etc. |
congt
approved these changes
Jul 3, 2025
nabs-m
approved these changes
Jul 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a bug in the logic for determining if a given layer has active animations.
When encountering an animation that has already completed (its completion time is in the past), we incorrectly determined it was not completed. This would lead to
waitForAnimationsToFinish()to continue running until it hits the animation wait timeout, which defaults to 2 seconds.