Login page 4 #13
Merged
Login page 4 #13
+1,982
−140
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
balog-b
requested changes
Aug 23, 2025
| try { | ||
| return await this.userService.getUserByName(username); | ||
| } catch (error) { | ||
| if (error instanceof BadRequestException) { |
There was a problem hiding this comment.
I see that you would like to create the user if it does not exist. The exception that getUserByName throws is of type NotFoundException, not BadRequestException.
| @@ -7,6 +7,11 @@ import { AppModule } from './app.module'; | |||
| async function bootstrap(): Promise<void> { | |||
| const app = await NestFactory.create(AppModule); | |||
|
|
|||
| app.enableCors({ | |||
| origin: process.env.FRONTEND_URL || 'http://localhost:3000', | |||
There was a problem hiding this comment.
It's advised to add the FRONTEND_URL env var to the .env.example file just so other people know that it needs to be set
bash.exe.stackdump
Outdated
There was a problem hiding this comment.
This file does not belong here. You should remove it
…o login-page-4
…o login-page-4
|
I think I fixed the issues, I had a little problem with stuff but I think I sorted it out! Please tell me if there's more issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
made a login page that gets the logged in user's chat page