Use curly braces for all variables #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Curly braces aid the interpreter to identify which part of a composed
string is the variable part to expand, and what the string to
concatenate to is.
In the case of
```bash
${volume_name}-${date_suffix}.tar
```
it worked, because -, and . are not allowd in variable names.
Use xz compression
Add proper file extension to tar invocations
|
Since we are currently missing any CI, have you tested your changes somewhere? ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Curly braces aid the interpreter to identify which part of a composed
string is the variable part to expand, and what the string to
concatenate to is.
In the case of
it worked, because -, and . are not allowd in variable names.
Use xz compression
Add proper file extension to tar invocations