Debug CI #1
Draft
Debug CI #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 5b7c48e. Co-authored-by: TÖRÖK Attila <[email protected]>
The current implementation was synchronous only, so that when an async callback was used, the menu was being disposed prematurely. This patch ensures that in case of asynchronous callbacks, the menu will be disposed after they finish.
This modal informs the user that they can use shortcuts for copy, cut, and paste instead of using the context menu. This modal is meant to be displayed when the browser does not support reading the clipboard.
Ruffle does not have direct clipboard access on web, so the current paste implementation from the context menu does not work. This patch intercepts the paste context menu callback, and uses the Clipboard API to ask the browser for the clipboard and update it before calling the callback. When the Clipboard API is not available, a modal informing the user about cut, copy, paste shortcuts is displayed.
kjarosh
force-pushed
the
master
branch
23 times, most recently
from
c14d93a to
f6eec74
Compare
kjarosh
force-pushed
the
master
branch
11 times, most recently
from
38c3bac to
23696a5
Compare
kjarosh
force-pushed
the
master
branch
16 times, most recently
from
30dd8af to
8fde551
Compare
kjarosh
force-pushed
the
master
branch
3 times, most recently
from
d328041 to
7ec3889
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.