-
Couldn't load subscription status.
- Fork 164
fix: return better error when using pack+python #2904
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Matej Vašek <[email protected]>
dcaa123 to
d5a60ea
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/lgtm
Much better UX
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lkingland, matejvasek The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2904 +/- ##
==========================================
+ Coverage 60.75% 61.51% +0.75%
==========================================
Files 129 129
Lines 16327 16330 +3
==========================================
+ Hits 9920 10045 +125
+ Misses 5479 5327 -152
- Partials 928 958 +30
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
picking knative#2904 Signed-off-by: Matej Vašek <[email protected]>
picking knative#2904 Signed-off-by: Matej Vašek <[email protected]>
|
/cherry-pick release-1.18 |
|
@matejvasek: new pull request created: #3090 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
No description provided.