Skip to content

Conversation

@twoGiants
Copy link

Changes

  • 🎁 tba ...
  • 🧹 tba ...

/kind enhancement

Fixes #tba...

Release Note


Docs


@knative-prow
Copy link

knative-prow bot commented Oct 22, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@knative-prow knative-prow bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/enhancement labels Oct 22, 2025
@knative-prow
Copy link

knative-prow bot commented Oct 22, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: twoGiants
Once this PR has been reviewed and has the lgtm label, please assign lkingland for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot requested review from jrangelramos and nainaz October 22, 2025 12:26
@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 22, 2025
@knative-prow-robot
Copy link

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow knative-prow bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 22, 2025
@twoGiants twoGiants force-pushed the issue-744-generate-github-actions-workflow branch from bd22332 to edad0e7 Compare October 22, 2025 14:09
Issue SRVOCF-744

Signed-off-by: Stanislav Jakuschevskij <[email protected]>
Issue SRVOCF-744

Signed-off-by: Stanislav Jakuschevskij <[email protected]>
Add 'func config ci' command as foundation for GitHub Actions
workflow generation. Extract function loader/saver interfaces
into cmd/common package and create cmd/testing factory for
reusable test helpers.

Issue SRVOCF-744

Signed-off-by: Stanislav Jakuschevskij <[email protected]>
Signed-off-by: Stanislav Jakuschevskij <[email protected]>
Add functionality to create GitHub Actions workflow directory and file
when running config ci command. Includes CIConfig struct for managing
workflow paths and permissions, with comprehensive test coverage.

Also fixes typo and refactors config tests to use helper functions.

Issue SRVOCF-744

Signed-off-by: Stanislav Jakuschevskij <[email protected]>
Signed-off-by: Stanislav Jakuschevskij <[email protected]>
@twoGiants twoGiants force-pushed the issue-744-generate-github-actions-workflow branch from edad0e7 to 2b2cc43 Compare October 24, 2025 16:48
@knative-prow knative-prow bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/enhancement needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants