Skip to content

setAttributesToHighlight method should allow adding empty array #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

setAttributesToHighlight method should allow adding empty array #110

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a7ac02a
DELETE setAttributesToHighlight list isNotEmpty assert
RBT22 Mar 9, 2023
c523c8f
_encodeMap fix for empty lists
RBT22 Mar 9, 2023
3a28eb4
setAttributesToRetrieve can be empty
RBT22 Mar 10, 2023
befb486
dependency update
RBT22 Mar 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/src/index_reference.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -360,7 +360,7 @@ class AlgoliaMultiIndexesReference {
host: '',
path: '',
queryParameters: (data as Map<String, dynamic>?)?.map((key, value) {
if (value is List) {
if (value is List && value.isNotEmpty) {
return MapEntry(key, value);
}
return MapEntry(key, value.toString());
Expand Down
2 changes: 0 additions & 2 deletions lib/src/query.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -301,7 +301,6 @@ class AlgoliaQuery {
/// Source: [Learn more](https://www.algolia.com/doc/api-reference/api-parameters/attributesToRetrieve/)
///
AlgoliaQuery setAttributesToRetrieve(List<String> value) {
assert(value.isNotEmpty, 'value can not be empty');
assert(!_parameters.containsKey('attributesToRetrieve'));
return _copyWithParameters(
<String, dynamic>{'attributesToRetrieve': value});
Expand Down Expand Up @@ -836,7 +835,6 @@ class AlgoliaQuery {
/// Source: [Learn more](https://www.algolia.com/doc/api-reference/api-parameters/attributesToHighlight/)
///
AlgoliaQuery setAttributesToHighlight(List<String> value) {
assert(value.isNotEmpty, 'value can not be empty');
assert(!_parameters.containsKey('attributesToHighlight'));
return _copyWithParameters(
<String, dynamic>{'attributesToHighlight': value});
Expand Down
Loading