wire format: omit the inner type tag empty slices and arrays #929
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jordens
commented
Jan 31, 2025
jordens
commented
- Wire format bump
Rely on fmt_array for the bulk formatting. This gives the compiler a bit more to play with for inlining and/or code size reduction.
|
This looks OK but it needs a wire-format bump so we need to wait until after 1.0 is released, when we have a bunch of stuff to wrap up into Wire Format Version 5. |
|
Still want to get this in, but the process will probably need to be:
It's that or we find a way to use version 4 by default and let people opt-in to version 5. We should probably have a road-map so they know when defmt releases are coming and which probe-rs versions they are going to need to have. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.