add impl Format for std::sync::Mutex
#978
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this introduces a new optional feature `std` and an initial `Format` implementation just for `Mutex`. the hope is that over time more and more `Format` impls for `std` can be added for those who need it. the trigger for this is that i broke the `embassy-sync` build for `std` by adding a `Format` derive to something which was using `Mutex` internally and it wasn't covered by CI there (which by now is rectified). in the ensuing conversation on Matrix it was stated that it might be nice to have `defmt` impls for `std` as well, even if only very few users would exist for this (i'm not one of them, which is how i ended up breaking CI). part of knurling-rs#979
rursprung
force-pushed
the
add-std-mutex-Format-impl
branch
from
09c7505 to
9ab9174
Compare
|
CI currently doesn't seem to test with different features, e.g. it doesn't seem to test with the |
|
Just copying what I said on #979, there are currently very few std targets where defmt works, and that needs fixing first. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this introduces a new optional feature
stdand an initialFormatimplementation just forMutex. the hope is that over time more and moreFormatimpls forstdcan be added for those who need it.the trigger for this is that i broke the
embassy-syncbuild forstdby adding aFormatderive to something which was usingMutexinternally and it wasn't covered by CI there (which by now is rectified). in the ensuing conversation on Matrix it was stated that it might be nice to havedefmtimpls forstdas well, even if only very few users would exist for this (i'm not one of them, which is how i ended up breaking CI).