[Trie] Fix trie contains function for empty string #954
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description
Currently
Trie().contains(word: "", matchPrefix: true))will returnfalse, which is wrong since the root node of aTrieis considered an empty string. This PR fixes this bug. More information can be found here or by checking implementations ofTriedata structure in other languages.There is actually already a test written for this, which is failing at the moment. So this PR also makes tests for
Triedata structure to pass.What has been done
containsfunction to returntruefor empty stringTrieproject toSwift 5. No code changes were required.How to test
Open
Trie.xcodeprojand make sure project builds and tests are passing.