Build-system: adding support for Apple Accelerate library - #2707
Merged
Merged
Conversation
lucbv
marked this pull request as draft
July 22, 2025 23:27
lucbv
force-pushed
the
BLAS_accelerate_support
branch
from
January 5, 2026 18:49
687f7fe to
14d9a14
Compare
lucbv
marked this pull request as ready for review
January 6, 2026 15:21
Contributor
|
@lucbv Could you rebase on develop? |
lucbv
force-pushed
the
BLAS_accelerate_support
branch
from
January 6, 2026 17:27
d9497ad to
6cb435a
Compare
Contributor
Author
|
Rebased |
JBludau
reviewed
Jan 6, 2026
brian-kelley
approved these changes
Jan 7, 2026
brian-kelley
left a comment
brian-kelley
left a comment
Contributor
There was a problem hiding this comment.
Aside from @JBludau's comment everything looks good to me!
Contributor
Author
|
Okay, I cleaned the CMake logic a bit and as a side effect, the ci build with accelerate is also a bit cleaner now. This should be good to go at this point : ) |
brian-kelley
approved these changes
Jan 7, 2026
JBludau
approved these changes
Jan 7, 2026
JBludau
left a comment
JBludau
left a comment
There was a problem hiding this comment.
The CMake part looks fine. Not sure if my other comment is relevant
| /* */ std::complex<float>* x, const KK_INT* x_inc); | ||
| void F77_BLAS_MANGLE(zscal, ZSCAL)(const KK_INT* N, const std::complex<double>* alpha, | ||
| /* */ std::complex<double>* x, const KK_INT* x_inc); | ||
| } // extern "C" |
There was a problem hiding this comment.
hmm that looks weird since it is touching the #else branch.
Contributor
Author
There was a problem hiding this comment.
It is fully contained in the "else" and the branch is based on which library is being used since they are written in different languages...
Adding option to request the library and modifying the BLAS logic to skip the Fortran check and correctly define the mangling macro for Accelerate. This last part might be an undue overload of the macro purpose? Signed-off-by: Luc Berger-Vergiat <lberge@sandia.gov>
This will allow us to make sure the logic we are adding it indeed working correctly and tested with the regular CI actions. Signed-off-by: Luc Berger-Vergiat <lberge@sandia.gov>
Actually including the proper header... renaming a bit the github action to make it clear which one tests Accelerate. Adding CXX flag to force using the new version of Accelerate and avoid deprecation warnings. Signed-off-by: Luc Berger-Vergiat <lberge@sandia.gov>
Further refactoring would be good in the future to centralize the various BLAS/CBLAS flavors and have them marshalled at configure time in a way that let's use less macros for all these different implementations that end up in the same Kokkos Kernels wrappers. Signed-off-by: Luc Berger-Vergiat <lberge@sandia.gov>
Signed-off-by: Luc Berger-Vergiat <lberge@sandia.gov>
Signed-off-by: Luc Berger-Vergiat <lberge@sandia.gov>
Signed-off-by: Luc Berger-Vergiat <lberge@sandia.gov>
Signed-off-by: Luc Berger-Vergiat <lberge@sandia.gov>
Signed-off-by: Luc Berger-Vergiat <lberge@sandia.gov>
Signed-off-by: Luc Berger-Vergiat <lberge@sandia.gov>
Signed-off-by: Luc Berger-Vergiat <lberge@sandia.gov>
Now the compiler and linker flags are specified using our cmake functions/macros which leads to cleaner code and hopefully leads to a good example for future reference. Signed-off-by: Luc Berger-Vergiat <lberge@sandia.gov>
After fixing the CMake logic, the osx-ci build can be cleaned up, we no longer need to pass the linker flag manually. Signed-off-by: Luc Berger-Vergiat <lberge@sandia.gov>
Some interfaces used very confusing/suspicious names for vectores and flags. This should look more standard and reasonable now! Signed-off-by: Luc Berger-Vergiat <lberge@sandia.gov>
lucbv
force-pushed
the
BLAS_accelerate_support
branch
from
January 8, 2026 23:47
ee6414b to
22ddff3
Compare
lucbv
added
AT2-SPECIAL-APPROVAL
JBludau
approved these changes
Jan 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding option to request the library and modifying the BLAS logic to skip the Fortran check and correctly define the mangling macro for Accelerate. This last part might be an undue overload of the macro purpose?