Menu fixes / tweaks - #988
Open
andrikpowell wants to merge 1 commit into
Open
andrikpowell wants to merge 1 commit into
andrikpowell wants to merge 1 commit into
Conversation
- simplify thermo logic / calls - thermos can be disabled (removed highlight) - use disabled instead of strict (disabled includes strict) - add some failure sounds - remove `&& CR_BRIGHT` - replace LoadDef with SaveDef in `M_DrawSave()`
| { | ||
| // Mouse highlight is always enabled | ||
| if (M_MouseHovered(item)) | ||
| return true; |
Collaborator
There was a problem hiding this comment.
I assume this is a remnant from nyan? Since the function is useless for us in dsda.
I think its ok to keep it here in dsda since Im sure there will be many more menu changes in the future.
Pedro-Beirao
approved these changes
Sep 15, 2026
Pedro-Beirao
left a comment
Pedro-Beirao
left a comment
Collaborator
There was a problem hiding this comment.
Looks good, thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
&& CR_BRIGHTM_DrawSave()