Skip to content

Remove #[SensitiveParameter] attributes for PHP 8.1 support #1034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jeromegamez merged 1 commit into from
Nov 27, 2025
Merged

Remove #[SensitiveParameter] attributes for PHP 8.1 support #1034

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/Firebase/AppCheck/AppCheckTokenGenerator.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@

/**
* @internal
*
* @todo Add #[SensitiveParameter] attribute to the private key once the minimum required PHP version is >=8.2
*/
final class AppCheckTokenGenerator
{
Expand All @@ -24,7 +26,6 @@ final class AppCheckTokenGenerator
*/
public function __construct(
private readonly string $clientEmail,
#[\SensitiveParameter]
private readonly string $privateKey,
?ClockInterface $clock = null,
) {
Expand Down
13 changes: 2 additions & 11 deletions src/Firebase/ServiceAccount.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,44 +6,35 @@

/**
* @internal
*
* @todo Add #[SensitiveParameter] attributes once the minimum required PHP version is >=8.2
*/
final class ServiceAccount
{
public function __construct(
/** @var non-empty-string */
public string $type,
/** @var non-empty-string */
#[\SensitiveParameter]
public string $projectId,
/** @var non-empty-string */
#[\SensitiveParameter]
public string $clientEmail,
/** @var non-empty-string */
#[\SensitiveParameter]
public string $privateKey,
/** @var non-empty-string|null */
#[\SensitiveParameter]
public ?string $clientId = null,
/** @var non-empty-string|null */
#[\SensitiveParameter]
public ?string $privateKeyId = null,
/** @var non-empty-string|null */
#[\SensitiveParameter]
public ?string $authUri = null,
/** @var non-empty-string|null */
#[\SensitiveParameter]
public ?string $tokenUri = null,
/** @var non-empty-string|null */
#[\SensitiveParameter]
public ?string $authProviderX509CertUrl = null,
/** @var non-empty-string|null */
#[\SensitiveParameter]
public ?string $clientX509CertUrl = null,
/** @var non-empty-string|null */
#[\SensitiveParameter]
public ?string $quotaProjectId = null,
/** @var non-empty-string|null */
#[\SensitiveParameter]
public ?string $universeDomain = null,
) {
}
Expand Down