feat: add beforeStageTasks to stagedUpdateRun #328
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
britaniar
changed the title
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
britaniar
commented
Nov 17, 2025
britaniar
force-pushed
the
addBeforeStageTasks
branch
from
9fee098 to
cdc9f47
Compare
britaniar
requested review from
Arvindthiru and
jwtty
and removed request for
jwtty
Arvindthiru
reviewed
Nov 18, 2025
Arvindthiru
reviewed
Nov 18, 2025
britaniar
requested review from
Arvindthiru and
jwtty
and removed request for
jwtty
Arvindthiru
reviewed
Nov 18, 2025
Arvindthiru
reviewed
Nov 18, 2025
Arvindthiru
reviewed
Nov 18, 2025
Arvindthiru
reviewed
Nov 18, 2025
Arvindthiru
reviewed
Nov 18, 2025
Arvindthiru
reviewed
Nov 18, 2025
britaniar
force-pushed
the
addBeforeStageTasks
branch
from
cdc9f47 to
a9b7520
Compare
Signed-off-by: Britania Rodriguez Reyes <[email protected]>
Signed-off-by: Britania Rodriguez Reyes <[email protected]>
Signed-off-by: Britania Rodriguez Reyes <[email protected]>
Signed-off-by: Britania Rodriguez Reyes <[email protected]>
Signed-off-by: Britania Rodriguez Reyes <[email protected]>
Signed-off-by: Britania Rodriguez Reyes <[email protected]>
britaniar
force-pushed
the
addBeforeStageTasks
branch
from
61f73a9 to
a349d04
Compare
Signed-off-by: Britania Rodriguez Reyes <[email protected]>
Arvindthiru
reviewed
Nov 20, 2025
Arvindthiru
reviewed
Nov 20, 2025
Arvindthiru
reviewed
Nov 21, 2025
Signed-off-by: Britania Rodriguez Reyes <[email protected]>
Signed-off-by: Britania Rodriguez Reyes <[email protected]>
Arvindthiru
reviewed
Nov 21, 2025
Arvindthiru
reviewed
Nov 21, 2025
Arvindthiru
reviewed
Nov 21, 2025
Arvindthiru
reviewed
Nov 21, 2025
Arvindthiru
reviewed
Nov 21, 2025
Arvindthiru
reviewed
Nov 21, 2025
Arvindthiru
reviewed
Nov 21, 2025
Arvindthiru
reviewed
Nov 21, 2025
Signed-off-by: Britania Rodriguez Reyes <[email protected]>
jwtty
reviewed
Nov 24, 2025
Signed-off-by: Britania Rodriguez Reyes <[email protected]>
Signed-off-by: Britania Rodriguez Reyes <[email protected]>
jwtty
reviewed
Nov 25, 2025
| } | ||
| updatingStage := &updateRunStatus.StagesStatus[updatingStageIndex] | ||
| approved, beforeStageTaskErr := r.checkBeforeStageTasksStatus(ctx, updatingStageIndex, updateRun) | ||
| if beforeStageTaskErr != nil { |
Collaborator
There was a problem hiding this comment.
if this err is Aborted, we need to mark stage to be failed: https://github.com/kubefleet-dev/kubefleet/blob/main/pkg/controllers/updaterun/execution.go#L79C3-L82C4. Since multiple such checks exist in this code, please create a defer function.
Collaborator
There was a problem hiding this comment.
found a potential bug: calculateMaxConcurrencyValue should return errIsAborted. cc @Arvindthiru please confirm and submit a separate fix PR.
Signed-off-by: Britania Rodriguez Reyes <[email protected]>
jwtty
reviewed
Nov 26, 2025
Signed-off-by: Britania Rodriguez Reyes <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
I have:
Added a check within update run execution to check for before stage tasks.
Returned unexpected error for TimedWait tasks as a before stage task, otherwise continue with approval task.
Check the different states of approval tasks.
Update the names of the approval requests to differentiate between before and after tasks.
Update current integration and e2e tests to include before stage tasks
Run
make reviewableto ensure this PR is ready for review.How has this code been tested
Special notes for your reviewer