-
Notifications
You must be signed in to change notification settings - Fork 11
docs: add resource placement TSG #46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
docs: add resource placement TSG #46
Conversation
Signed-off-by: Wei Weng <[email protected]>
| The following command lists all `ResourceBindings` instances that are associated with `ResourcePlacement`: | ||
|
|
||
| ```bash | ||
| kubectl get resourcebinding -n <namespace> -l kubernetes-fleet.io/parent-CRP={RPName} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We use kubernetes-fleet.io/parent-CRP even for RP
britaniar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some formatting suggestions as well. Trying to make sure it seem user friendly.
| kubectl describe resourceplacement <name> -n <namespace> | ||
| ``` | ||
|
|
||
| The complete progression of `ResourcePlacement` is as follows: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if we should make the file name for the conditions more generic, so it is applied to both CRP and RP and customer does not get confused.
Does not need to be addressed in this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what does "file name" refer to here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think @britaniar meant file names like ClusterResourcePlacementScheduled.md and ClusterResourcePlacementRolloutStarted.md. These are applicable to both RP and CRP. We should probably modify those in separate PRs to make them cover both RP and CRP
| kubectl describe resourceplacement <name> -n <namespace> | ||
| ``` | ||
|
|
||
| The complete progression of `ResourcePlacement` is as follows: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what does "file name" refer to here?
| - `ResourceBinding` | ||
| - `Work` | ||
|
|
||
| Please read the [Fleet API reference](docs/api-reference) for more details about each object. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
btw, is that api-reference up to date?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not up to date. But doing that in a different PR #47
Signed-off-by: Wei Weng <[email protected]>
Signed-off-by: Wei Weng <[email protected]>
Signed-off-by: Wei Weng <[email protected]>
4842dd2 to
30a2c44
Compare
Signed-off-by: Wei Weng <[email protected]>
add resource placement TSG