Skip to content

feat(ws): add namespace field for ConfigMap resource and update PVC/Kind validation regex #132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: notebooks-v2
Choose a base branch
from
Open

feat(ws): add namespace field for ConfigMap resource and update PVC/Kind validation regex #132

wants to merge 3 commits into from

Conversation

@mishraprafful
Copy link

@mishraprafful mishraprafful commented Nov 18, 2024 •
edited
Loading

Related PRs/Issues

Fixes #125

Describe your changes

  • Updated regex for validation of WorkspaceKind and PVC cea9552
  • Added namespace filed for ConfigMap resource 7249333

Comments

None

@google-oss-prow
Copy link

google-oss-prow bot commented Nov 18, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign kimwnasptd for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mishraprafful mishraprafful marked this pull request as ready for review November 18, 2024 21:47
@thesuperzapper thesuperzapper changed the title feat: add namespace field for ConfigMap resource and update PVC/Kind validation regex feat(ws): add namespace field for ConfigMap resource and update PVC/Kind validation regex Dec 11, 2024
@github-actions
Copy link

github-actions bot commented Mar 8, 2025

This pull request has been automatically marked as stale because it has not had recent activity.
It will be closed if no further activity occurs.
Thank you for your contributions.

Members may comment /lifecycle frozen to prevent this pull request from being marked as stale.

@google-oss-prow google-oss-prow bot added size/L and removed size/M labels Apr 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kimwnasptd kimwnasptd Awaiting requested review from kimwnasptd

@thesuperzapper thesuperzapper Awaiting requested review from thesuperzapper

Assignees

No one assigned

Labels

size/L

Projects

Kubeflow Notebooks
Status: Needs Triage

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@mishraprafful