fix: infinite status reconciliation loop in notebook controller - #1343
fix: infinite status reconciliation loop in notebook controller#1343juliusvonkohout wants to merge 2 commits into
Conversation
Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com>
|
docker.io/jvonkoho/notebook-controller:pr-1343 if you want to test it. It works well in practice. |
christian-heusel
left a comment
There was a problem hiding this comment.
This pull request is currently lacking a few quite basic things, please add them and we can proceed with the review itself:
- Motivation: What is the bug that is being fixed here?
- Reproducer: How can the bug be reproduced by a developer?
- Implementation: How is the submitted changeset fixing the issue?
Also I suspect you used AI in the creation of this change, please add appropriate trailers in order comply with the Kubeflow AI policy 😊
Alternative to #1341
The reconcilliation loop creates a lot of logging costs and api server load if you have for example 250 notebooks on a cluster.
Imagine this continously at full speed without interruption increasing the revisions.