chore: enforce planning label rules for issues #421
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/ok-to-test |
paulovmr
suggested changes
Jun 23, 2025
thaorell
reviewed
Jun 23, 2025
thesuperzapper
requested changes
Jun 26, 2025
There was a problem hiding this comment.
We will need to update the labels used in this PR to match the actual labels we decided to use for planning:
kind/plan-epickind/plan-featurekind/plan-task
related #361 (comment)
andyatmiami
force-pushed
the
chore/planning-labels-gha
branch
from
c5dda79 to
b5fad92
Compare
andyatmiami
force-pushed
the
chore/planning-labels-gha
branch
from
b5fad92 to
ed32e1a
Compare
related: kubeflow#327 This new GitHub Actions workflow listens for the 'opened' and 'labeled' events on GitHub issues and ensures any issue opened (or labelled) with a `kind/plan-xxx` label meets the following criteria: - only users listed in the `AUTHORIZED_USER` JSON array can label an issue with the `kind/plan-xxx` label - at most one of the `kind/plan-xxx` labels can exist on a given issue The set of supported/expected `kind/plan-xxx` labels are: - `kind/plan-epic` - `kind/plan-feature` - `kind/plan-task` If an issue (with a `kind/plan-xxx` label) is **opened** by a non-authorized user - the issue will be automatically closed when the GitHub action fires. If an issue is labelled with the `kind/plan-xxx` label by an unauthorized user - the `kind/plan-xxx` label is removed. In both cases, a GitHub comment is added to the issue explaining why the issue was updated by the bot. Please note, when opening a GH issue - **BOTH** the `opened` and `labeled` events will fire (if the issue has a label on it). As such, the GitHub action in this PR was deliberately structured to account for multiple instances running in parallel on the same underlying GitHub issue. Also, this work complements kubeflow#361 - which defines GH issue templates that use the labels in a manner appropriate to satisfy the checks of this action. Signed-off-by: Andy Stoneberg <[email protected]>
thesuperzapper
changed the title
thesuperzapper
changed the title
andyatmiami
force-pushed
the
chore/planning-labels-gha
branch
from
ed32e1a to
a27d378
Compare
|
Lets see if this works. /lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: thesuperzapper The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
github-project-automation
bot
moved this from Needs Triage
to Done
in Kubeflow Notebooks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related: #327
This new GitHub Actions workflow listens for the 'opened' and 'labeled' events on GitHub issues and ensures any issue opened (or labelled) with a
kind/plan-xxxlabel meets the following criteria:AUTHORIZED_USERJSON array can label an issue with thekind/plan-xxxlabelkind/plan-xxxlabels can exist on a given issueThe set of supported/expected
kind/plan-xxxlabels are:kind/plan-epickind/plan-featurekind/plan-taskIf an issue (with a
kind/plan-xxxlabel) is opened by a non-authorized user - the issue will be automatically closed when the GitHub action fires.If an issue is labelled with the
kind/plan-xxxlabel by an unauthorized user - thekind/plan-xxxlabel is removed.In both cases, a GitHub comment is added to the issue explaining why the issue was updated by the bot.
Please note, when opening a GH issue - BOTH the
openedandlabeledevents will fire (if the issue has a label on it). As such, the GitHub action in this PR was deliberately structured to account for multiple instances running in parallel on the same underlying GitHub issue.Also, this work complements #361 - which defines GH issue templates that use the labels in a manner appropriate to satisfy the checks of this action.