Skip to content

Conversation

abdallahsamabd
Copy link

added test for cmd package, testing get envs vars methods

Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign thesuperzapper for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

@andyatmiami andyatmiami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@abdallahsamabd

Really like the thought/care you put into making these table-driven tests... thank you for that!

However, we had discussed a week or so ago, and decided amongst the community that we really want all tests to leverage the ginkgo (and where applicable gomega) packages to provide a "consistent look and feel" through the repository..

Please add the required and minimal ginkgo scaffolding and let me know when ready for re-review.

Copy link

This pull request has been automatically marked as stale because it has not had recent activity.
It will be closed if no further activity occurs.
Thank you for your contributions.

Members may comment /lifecycle frozen to prevent this pull request from being marked as stale.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Needs Triage
Development

Successfully merging this pull request may close these issues.

2 participants