Skip to content

chore(ws): enforce component specific imports #475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

paulovmr
Copy link

@paulovmr paulovmr commented Jul 9, 2025

Enforce component specific imports for @patternfly, date-fns and lodash.

If a general import is made, an error like this will happen:

error  '@patternfly/react-core' import is restricted from being used. Use specific component imports: @patternfly/react-core/dist/esm/components/ComponentName  no-restricted-imports

@github-project-automation github-project-automation bot moved this to Needs Triage in Kubeflow Notebooks Jul 9, 2025
@google-oss-prow google-oss-prow bot added the area/frontend area - related to frontend components label Jul 9, 2025
@google-oss-prow google-oss-prow bot requested review from ederign and kimwnasptd July 9, 2025 14:29
@google-oss-prow google-oss-prow bot added area/v2 area - version - kubeflow notebooks v2 size/XL labels Jul 9, 2025
@paulovmr
Copy link
Author

paulovmr commented Jul 9, 2025

/ok-to-test

@caponetto
Copy link

/lgtm

@paulovmr paulovmr force-pushed the notebooks-v2-tree-shaking branch from 76505d9 to 9fe6caf Compare July 21, 2025 19:10
@google-oss-prow google-oss-prow bot removed the lgtm label Jul 21, 2025
@caponetto
Copy link

/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label Jul 21, 2025
@ederign
Copy link
Member

ederign commented Jul 21, 2025

/lgtm
/approve

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ederign

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 3454818 into kubeflow:notebooks-v2 Jul 21, 2025
7 checks passed
@github-project-automation github-project-automation bot moved this from Needs Triage to Done in Kubeflow Notebooks Jul 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/frontend area - related to frontend components area/v2 area - version - kubeflow notebooks v2 lgtm ok-to-test size/XL
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants