feat(ws): Define k8s workload manifest for frontend component #404 #487
Conversation
google-oss-prow
bot
added
the
area/frontend
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
i'll ask for a couple quick edits that jump out now - but please be aware I'll do a much more comprehensive review on Monday where I will try to deploy these changes along with base Kubeflow manifests and backend component to exercise end-to-end functionality.
For now, 2 easy "structure" changes I will ask for:
-
workspaces/frontend/manifests/kustomizeshould be the "base" directory (no/configfolder) -
options/istioshould be the root folder in which you place the istio-specific resources
| livenessProbe: | ||
| httpGet: | ||
| path: / | ||
| port: 8080 |
There was a problem hiding this comment.
use the named port value of http-frontend here
| readinessProbe: | ||
| httpGet: | ||
| path: / | ||
| port: 8080 |
There was a problem hiding this comment.
| http: | ||
| - match: | ||
| - uri: | ||
| prefix: /notebooks |
There was a problem hiding this comment.
I think we'll want to call this /workspaces to be more future-proofed
but most importantly - it should be 'aligned' with what backend is setting..
i.e.
- frontend:
/workspaces - backend:
/workspaces/api
Noa-limoy
force-pushed
the
frontend_k8s_deploy/404
branch
2 times, most recently
from
7edcef8 to
7c11794
Compare
| selector: | ||
| matchLabels: | ||
| app.kubernetes.io/name: kubeflow-notebooks | ||
| app.kubernetes.io/component: frontend |
There was a problem hiding this comment.
This doesnt match
we should make them align
| apiVersion: kustomize.config.k8s.io/v1beta1 | ||
| kind: Kustomization | ||
|
|
||
| namespace: kubeflow-system |
There was a problem hiding this comment.
all part in virtual service , look for service in workspace-controller-system, however , we are explicitly deploying bits in kubeflow-system
|
@harshad16: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
…w#404 Signed-off-by: Noa <[email protected]>
Noa-limoy
force-pushed
the
frontend_k8s_deploy/404
branch
from
7c11794 to
a2a8b17
Compare
|
/lgtm verified these changes with help of a script I have been working on to deploy Central Dashboard in user requests to |
|
/ok-to-test |
closes: #404
In this PR I have deployed the frontend component to Kubernetes using Kustomize.