Skip to content

fix(nb): fixed function to get notebook status from container state #567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: notebooks-v1
Choose a base branch
from
Open

fix(nb): fixed function to get notebook status from container state #567

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3c52d4c
fix(jupyter backend): fixed function to get status from container state
mathis-marcotte Sep 5, 2025
2973d8f
fix(jupyter backend): fixed status test for container state
mathis-marcotte Sep 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions components/crud-web-apps/jupyter/backend/apps/common/status.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,9 +133,9 @@ def get_status_from_container_state(notebook):

# If the Notebook is initializing, the status will be waiting
waiting_state = container_state["waiting"]
if ["reason"] == 'PodInitializing':
if waiting_state["reason"] == 'PodInitializing':
status_phase = status.STATUS_PHASE.WAITING
status_message = waiting_state.get("reason", "Undetermined reason.")
status_message = waiting_state["reason"]
return status_phase, status_message

# In any other case, the status will be warning with a "reason:
Expand Down
4 changes: 2 additions & 2 deletions components/crud-web-apps/jupyter/backend/apps/common/status_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,6 @@ def test_no_message_container_state(self):

self.assertEqual(
status.get_status_from_container_state(container_state),
("warning",
"PodInitializing: No available message for container state.")
("waiting",
"PodInitializing")
)