Skip to content

Conversation

yashpal2104
Copy link

@yashpal2104 yashpal2104 commented Sep 5, 2025

Key Changes

  • Adds a comprehensive e2e test suite targeting Istio-enabled scenarios.
  • Tests common installation/uninstallation/wait and verifies istio resources and we will also need "isInstalled" + "install" + "wait" style checks to handle this istio-ingressgateway resource.
  • Adds Cross-platform istioctl installation for testing locally
  • Provides a foundation for future Istio-related test expansion and more robust CI coverage.

@github-project-automation github-project-automation bot moved this to Needs Triage in Kubeflow Notebooks Sep 5, 2025
@google-oss-prow google-oss-prow bot added the area/ci area - related to ci label Sep 5, 2025
@yashpal2104 yashpal2104 marked this pull request as draft September 5, 2025 17:11
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign kimwnasptd for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot added the area/controller area - related to controller components label Sep 5, 2025
@google-oss-prow google-oss-prow bot added area/v2 area - version - kubeflow notebooks v2 do-not-merge/work-in-progress size/XL labels Sep 5, 2025
@yashpal2104 yashpal2104 changed the title Istio e2e test suite test: Istio e2e test suite Sep 5, 2025
- Add InstallIstioctl() function to download and install istioctl binary
- Add InstallIstioMinimalWithIngress() to set up Istio with minimal profile
- Add IsIstioInstalled() and WaitIstioctlAvailable() helper functions
- Use positional formatting in URL template for istioctl downloads
- Support configurable Istio namespace for installation
- Add error handling and proper command output redirection

This enables e2e tests to automatically set up Istio service mesh
components required for workspace HTTP proxy functionality.

Signed-off-by: Yash Pal <[email protected]>
…gement

- Add InstallIstioctl() with OS/arch detection for Linux, macOS, Windows
- Add comprehensive Istio gateway functions (install, check, wait)
- Enhance WaitIstioAvailable() to verify all Istio components
- Add UninstallIstioctl() for complete cleanup
- Use platform-specific download methods with fallbacks

Signed-off-by: Yash Pal <[email protected]>
@google-oss-prow google-oss-prow bot added size/L and removed size/M labels Sep 7, 2025
…tests

- Add istioctl binary download and installation for multiple platforms
- Implement Istio minimal profile deployment with ingress gateway
- Add comprehensive Istio availability checks and wait functions
- Improve error handling and cleanup for test components
- Add platform-specific binary management for Windows/Linux/macOS

Signed-off-by: Yash Pal <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ci area - related to ci area/controller area - related to controller components area/v2 area - version - kubeflow notebooks v2 do-not-merge/work-in-progress size/L
Projects
Status: Needs Triage
Development

Successfully merging this pull request may close these issues.

1 participant