-
Notifications
You must be signed in to change notification settings - Fork 1.8k
[WIP]chore(backend): migrate ResourceReference model to GORM v2 #11918
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP]chore(backend): migrate ResourceReference model to GORM v2 #11918
Conversation
|
Hi @kaikaila. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
🚫 This command cannot be processed. Only organization members or owners can use the commands. |
Signed-off-by: kaikaila <[email protected]>
Signed-off-by: kaikaila <[email protected]>
473486c to
b727103
Compare
|
Hi @mprahl – following your earlier suggestion on Slack, I just opened this PR to begin migrating the It's the first in a staged series. The design doc with full context (breaking change audit, PoC, migration plan) will be posted in Slack on Monday morning, but this PR already aligns with the proposed strategy and passes all tests. Would love to get your thoughts on structure and next steps 🙏 |
…rmsg.sys) Signed-off-by: kaikaila <[email protected]>
Signed-off-by: kaikaila <[email protected]>
Signed-off-by: kaikaila <[email protected]>
|
Hi @humair, CI/CD failed previously due to this MySQL 8.4 error in the pod logs: I've tested by temporarily downgrading to This suggests the root cause is in the I’m happy to revert it back to 8.4 if there's a known fix or replacement image. Let me know how you’d like to proceed. |
Signed-off-by: kaikaila <[email protected]>
a95c645 to
6819530
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
merged into a larger migration in #11929 |
Background
As part of the migration from GORM v1 to GORM v2, this PR updates the
ResourceReferencemodel to use the new struct tags and conventions.Changes
gorm:"primary_key"tags withgorm:"primaryKey"ResourceUUID,ResourceType, andReferenceTypegorm:"column:..."for compatibilityVerification
AutoMigrate(&ResourceReference{})successfully tested via local GORM v2 playgroundTestResourceReferenceStoreinresource_reference_store_test.goTestParseResourceReferencesinlist_test.goserver_test.go,converter_test.goNotes
This PR is the first in a series of staged model migrations to GORM v2.
Design Doc will be posted in the community Slack on Monday morning.
No runtime logic is changed. This is a safe schema-only update.
Just saw that a couple CI checks failed. I’m currently investigating the errors and will follow up with a fix shortly.
Marking this PR as
[WIP]for now to avoid unnecessary reviews.