Skip to content

test (refactor): adding POC Sdk Compile tests #11983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 26 commits into
base: master
Choose a base branch
from
Draft

test (refactor): adding POC Sdk Compile tests #11983

wants to merge 26 commits into from

Conversation

@nsingla
Copy link
Contributor

@nsingla nsingla commented Jun 16, 2025 •
edited
Loading

Description of your changes:

Checklist:

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign droctothorpe for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow
Copy link

Hi @nsingla. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@github-actions
Copy link

🚫 This command cannot be processed. Only organization members or owners can use the commands.

@nsingla nsingla force-pushed the sdk-tests branch 6 times, most recently from 545f0df to 5d1d4ce Compare June 17, 2025 18:28
nsingla added 14 commits July 18, 2025 11:13
@nsingla
adding POC for API tests in goinkgo
38822b7 
Signed-off-by: Nelesh Singla <[email protected]>

rh-pre-commit.version: 2.3.2
rh-pre-commit.check-secrets: ENABLED
@nsingla
adding parameterized test example (with some basic negative scenarios…
8ca163a 
…) and reorganizing pipeline files in the resource dir

Signed-off-by: Nelesh Singla <[email protected]>

rh-pre-commit.version: 2.3.2
rh-pre-commit.check-secrets: ENABLED
@nsingla
tagging tests with ginkgo labels, so that filtered tests can run
0fc00ed 
Signed-off-by: Nelesh Singla <[email protected]>

rh-pre-commit.version: 2.3.2
rh-pre-commit.check-secrets: ENABLED
@nsingla
couple of extra test cases and making tests parallel executable
df56d82 
Signed-off-by: Nelesh Singla <[email protected]>

rh-pre-commit.version: 2.3.2
rh-pre-commit.check-secrets: ENABLED
@nsingla
resolving some feedback comments and adding more coverage for pipelin…
2f2590b 
…e upload api tests

Signed-off-by: Nelesh Singla <[email protected]>

rh-pre-commit.version: 2.3.2
rh-pre-commit.check-secrets: ENABLED
@nsingla
adding pipeline upload version api tests
689b02e 
Signed-off-by: Nelesh Singla <[email protected]>

rh-pre-commit.version: 2.3.2
rh-pre-commit.check-secrets: ENABLED
@nsingla
adding a check to verify that the pipeline doesn't get created during…
80c0d6f 
… an expected failing scenario

Signed-off-by: Nelesh Singla <[email protected]>

rh-pre-commit.version: 2.3.2
rh-pre-commit.check-secrets: ENABLED
@nsingla
adding severity and test type enums and using those as labels in the …
e8995ce 
…tests

Signed-off-by: Nelesh Singla <[email protected]>

rh-pre-commit.version: 2.3.2
rh-pre-commit.check-secrets: ENABLED
@nsingla
adding custom report and suite config and moving some utils methods t…
eb323ca 
…o utility files

Signed-off-by: Nelesh Singla <[email protected]>

rh-pre-commit.version: 2.3.2
rh-pre-commit.check-secrets: ENABLED
@nsingla
fixing parallelization and add a stubb code to attach attachments to …
7c79f1b 
…reports on test failure

Signed-off-by: Nelesh Singla <[email protected]>

rh-pre-commit.version: 2.3.2
rh-pre-commit.check-secrets: ENABLED
@nsingla
logging test logs to log file per test
17c1a93 
Signed-off-by: Nelesh Singla <[email protected]>

rh-pre-commit.version: 2.3.2
rh-pre-commit.check-secrets: ENABLED
@nsingla
capturing logs in a log file after each test
ce3ec61 
Signed-off-by: Nelesh Singla <[email protected]>

rh-pre-commit.version: 2.3.2
rh-pre-commit.check-secrets: ENABLED
@nsingla
adding reports and logs dir to git ignore
8431923 
Signed-off-by: Nelesh Singla <[email protected]>

rh-pre-commit.version: 2.3.2
rh-pre-commit.check-secrets: ENABLED
@nsingla
adding a logger wrapper to do pretty printing of logs
92f26b9 
Signed-off-by: Nelesh Singla <[email protected]>

rh-pre-commit.version: 2.3.2
rh-pre-commit.check-secrets: ENABLED
nsingla added 11 commits July 18, 2025 11:13
@nsingla
moving pipeline files to a common directory so that every test in the…
b3f0636 
… project can refer it and adding a check to verify that the uploaded pipeline spec matches the input file

rh-pre-commit.version: 2.3.2
rh-pre-commit.check-secrets: ENABLED

Signed-off-by: Nelesh Singla <[email protected]>
@nsingla
updating kfp version
248421a 
rh-pre-commit.version: 2.3.2
rh-pre-commit.check-secrets: ENABLED

Signed-off-by: Nelesh Singla <[email protected]>
@nsingla
adding a kep for test refactor
d68ce3e 
rh-pre-commit.version: 2.3.2
rh-pre-commit.check-secrets: ENABLED
@nsingla
fixing table format
e0c999f 
rh-pre-commit.version: 2.3.2
rh-pre-commit.check-secrets: ENABLED
@nsingla
fixing markdown format
6e7733d 
rh-pre-commit.version: 2.3.2
rh-pre-commit.check-secrets: ENABLED

Signed-off-by: Nelesh Singla <[email protected]>
@nsingla
Inserting table of contents
1ad9977 
rh-pre-commit.version: 2.3.2
rh-pre-commit.check-secrets: ENABLED

Signed-off-by: Nelesh Singla <[email protected]>
@nsingla
changing image background to white
f0063d3 
rh-pre-commit.version: 2.3.2
rh-pre-commit.check-secrets: ENABLED
@nsingla
a simple POC for SDK compilation tests
506f383 
rh-pre-commit.version: 2.3.2
rh-pre-commit.check-secrets: ENABLED

Signed-off-by: Nelesh Singla <[email protected]>
@nsingla
adding yaml validation
efe8c7a 
rh-pre-commit.version: 2.3.2
rh-pre-commit.check-secrets: ENABLED

Signed-off-by: Nelesh Singla <[email protected]>
@nsingla
upgrading yapf and adding allure pytest dependency
19e6b7f 
rh-pre-commit.version: 2.3.2
rh-pre-commit.check-secrets: ENABLED

Signed-off-by: Nelesh Singla <[email protected]>
@nsingla
adding an option to traverse through a node tree for nested pipelines
87c7c7f 
Signed-off-by: Nelesh Singla <[email protected]>

rh-pre-commit.version: 2.3.2
rh-pre-commit.check-secrets: ENABLED
@nsingla
minor cleanup
fb35ff6 
rh-pre-commit.version: 2.3.2
rh-pre-commit.check-secrets: ENABLED

Signed-off-by: Nelesh Singla <[email protected]>
@nsingla nsingla mentioned this pull request Jul 29, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@droctothorpe droctothorpe Awaiting requested review from droctothorpe

@gmfrasca gmfrasca Awaiting requested review from gmfrasca

@HumairAK HumairAK Awaiting requested review from HumairAK

Assignees

No one assigned

Labels

do-not-merge/work-in-progress needs-ok-to-test size/XXL

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@nsingla