docs: Add a --insecure flag for the Kubernetes native API migration script #12286
Conversation
Signed-off-by: mprahl <[email protected]>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| help="KFP pipeline server host (e.g., https://<host>). Defaults to the value of the KFP_SERVER_HOST environment variable.") | ||
| parser.add_argument("--token", default=os.getenv("KFP_BEARER_TOKEN"), help="Bearer token for authentication. Defaults to the value of the KFP_BEARER_TOKEN environment variable.") | ||
| parser.add_argument("--ca-bundle", default=os.getenv("CA_BUNDLE"), help="Path to custom CA bundle file. Defaults to the value of the CA_BUNDLE environment variable") | ||
| parser.add_argument("--insecure", "--skip-tls-verify", dest="skip_tls_verify", action="store_true", |
There was a problem hiding this comment.
Is there a reason why we're using both --insecure and --skip-tls-verify flags here? Both seem to be achieving the same functionality.
There was a problem hiding this comment.
No reason in particular. We can pick one.
| parser.add_argument("--kfp-server-host", default=os.getenv("KFP_SERVER_HOST"), required=True, | ||
| help="KFP pipeline server host (e.g., https://<host>). Defaults to the value of the KFP_SERVER_HOST environment variable.") | ||
| parser.add_argument("--token", default=os.getenv("KFP_BEARER_TOKEN"), help="Bearer token for authentication. Defaults to the value of the KFP_BEARER_TOKEN environment variable.") | ||
| parser.add_argument("--ca-bundle", default=os.getenv("CA_BUNDLE"), help="Path to custom CA bundle file. Defaults to the value of the CA_BUNDLE environment variable") |
There was a problem hiding this comment.
The code allows --ca-bundle and --insecure to be used together, aren't these supposed to be mutually exclusive?
There was a problem hiding this comment.
Well, --insecure takes priority in the code.
|
|
||
| # Suppress urllib3 warnings when explicitly running with insecure TLS | ||
| if args.skip_tls_verify: | ||
| urllib3.disable_warnings(urllib3.exceptions.InsecureRequestWarning) |
There was a problem hiding this comment.
We could add a warning here so that the users are explicitly reminded they're running in insecure mode:
print("WARNING: TLS certificate verification is disabled. This connection is insecure!", file=sys.stderr)
2 participants
Description of your changes:
Checklist: