Skip to content

Conversation

RavinduWeerakoon
Copy link

This allows users to install newer versions of Click while maintaining compatibility with the SDK.

Fixes #12361

@google-oss-prow google-oss-prow bot requested a review from DharmitD October 15, 2025 13:30
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign chensun for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

Hi @RavinduWeerakoon. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

🚫 This command cannot be processed. Only organization members or owners can use the commands.

@HumairAK
Copy link
Collaborator

HumairAK commented Oct 21, 2025

thanks @RavinduWeerakoon can you rebase and sign off your commit (so it passes the DCO check)

@HumairAK HumairAK marked this pull request as ready for review October 21, 2025 14:17
@google-oss-prow google-oss-prow bot requested a review from zazulam October 21, 2025 14:17
@HumairAK HumairAK requested review from HumairAK and removed request for DharmitD, droctothorpe and zazulam October 21, 2025 14:17
@RavinduWeerakoon
Copy link
Author

@HumairAK Done .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

chore(sdk): allow installing click > 8.1.8

2 participants