fix(backend): Remove the default workspace configuration #12369
Conversation
|
Skipping CI for Draft Pull Request. |
mprahl
force-pushed
the
remove-default-workspace-config
branch
from
7beac26 to
6454ca1
Compare
mprahl
force-pushed
the
remove-default-workspace-config
branch
from
6454ca1 to
064550e
Compare
|
/cc @VaniHaripriya |
|
/lgtm |
| expectError: false, | ||
| }, | ||
| { | ||
| name: "workspace with nil Kubernetes config", |
There was a problem hiding this comment.
What is the reasoning behind completely removing the test cases for workspace with nil K8s config?
There was a problem hiding this comment.
It's because the test case workspace with size specified and default workspace now covers this scenario.
| } | ||
| } | ||
|
|
||
| if len(pvcSpec.AccessModes) == 0 { |
There was a problem hiding this comment.
It would be helpful to have a comment here explaining pvcSpec.AccessModes
This was added as a mistake as this is environment specific and not a safe default. Signed-off-by: mprahl <[email protected]>
mprahl
force-pushed
the
remove-default-workspace-config
branch
from
064550e to
cd3b97d
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
4 participants
Description of your changes:
This was added as a mistake as this is environment specific and not a safe default.
Checklist: