Skip to content

Conversation

sduvvuri1603
Copy link

Description of changes

  • Treat ErrResolvedParameterNull as skip for optional Kubernetes inputs and ensure the driver’s pod spec patch includes certs.
  • Add missing_kubernetes_optional_inputs pipeline and regenerated compiler goldens covering secrets/configmaps, node selector, node affinity, and tolerations missing-input scenarios.

Testing

  • Manual: ran node selector, affinity, secrets/configmaps pipelines in Kind (no launcher crashes).
  • ginkgo -v ./backend/test/compiler -- -createGoldenFiles=true -updateCompiledFiles=true (pass)

Resolves: #11899

Copy link

Hi @sduvvuri1603. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

🚫 This command cannot be processed. Only organization members or owners can use the commands.

@google-oss-prow google-oss-prow bot requested review from HumairAK and zazulam October 17, 2025 18:07
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign humairak for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sduvvuri1603 sduvvuri1603 force-pushed the debug/secret-configmap branch from 2ca0cad to c172b70 Compare October 17, 2025 18:12
@alyssacgoins
Copy link
Contributor

/ok-to-test

Copy link

Approvals successfully granted for pending runs.

Sruthi Duvvuri and others added 3 commits October 20, 2025 11:54
@sduvvuri1603 sduvvuri1603 force-pushed the debug/secret-configmap branch from 2d62972 to f4fc7aa Compare October 20, 2025 15:55
@mprahl
Copy link
Collaborator

mprahl commented Oct 20, 2025

/ok-to-test

Copy link

Approvals successfully granted for pending runs.

@alyssacgoins
Copy link
Contributor

/ok-to-test

Copy link

Approvals successfully granted for pending runs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[bug] Kubernetes platform runtime parameters don't work for optional case

3 participants